Simplify PING call, expect default response#23
Conversation
|
@mc-nv , could you take a look? 🙏 |
|
@kjocevicius thank you for your contribution. Have you completed the CLA requirements? I know it can be a hassle, but it's one of those things that our lawyers insist upon. Thank you. |
@whoisj I checked with our legal people and they took care of CCLA today 👍 |
whoisj
left a comment
There was a problem hiding this comment.
LGTM. I'll run it through internal CI labs and merge once everything passes.
@kjocevicius, thanks for submitting this. Received the CLA today, so just the CI pass to go before we can merge.
|
@whoisj I don't know about the internal CI, but Github CI seems to be broken due to version mismatches for a while now. Is this expected? |
|
cc @whoisj please release the new redis_cache version 🙏 |
This simplifies PING call during the initialisation, to pass no parameters and expect the default response.
Why?
My motivation for this change is to enable support of Redis under Envoy proxy:
error: creating server: Internal - Failed to initialise RedisCache: Failed to ping Redis server.)PINGresponse without parameter isPONG- that's how Envoy Redis also behaves.Testing
I performed some manual tests to verify this change behaves as expected: